Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: get network config from foundry.toml #715

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

iosh
Copy link

@iosh iosh commented Oct 27, 2024

Get network config from foundry.toml to replace hardcoded URLs.

Add smol-toml package to parse the toml config

resolve #709

Copy link

changeset-bot bot commented Oct 27, 2024

⚠️ No Changeset found

Latest commit: 4228738

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@iosh
Copy link
Author

iosh commented Oct 27, 2024

Hi @agostbiro I am interested in contributing more to the project, so please let me know if there is anything I can do.

@agostbiro agostbiro self-requested a review October 28, 2024 20:11
Copy link
Member

@agostbiro agostbiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@agostbiro
Copy link
Member

Hi @agostbiro I am interested in contributing more to the project, so please let me know if there is anything I can do.

Awesome, appreciate it! Feel free to have a look at the issues in the backlog and ping me if you see anything interesting. I'll check if the issue is up-to-date and worth doing.

@agostbiro agostbiro merged commit a6f3de6 into NomicFoundation:feat/solidity-tests Oct 28, 2024
38 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants